[llvm-commits] [llvm] r156591 - in /llvm/trunk: include/llvm/Support/FileSystem.h lib/Support/Unix/PathV2.inc lib/Support/Windows/PathV2.inc

[Eric Christopher]

On May 15, 2012, at 5:31 PM, Nick Kledzik <kledzik at apple.com> wrote:

> On May 15, 2012, at 5:27 PM, Eric Christopher wrote:
>> On May 15, 2012, at 4:58 PM, Eric Christopher <echristo at apple.com> wrote:
>> 
>>>> I've been working on linker support and also need to be able to (on Unix) to set the 'x' bit on created files.   But my thinking was to be more abstract.  In my patch, I added a new parameter "bool private_file=true".  When it is set,  on unix the open permissions is 0600, but when false, it is 0644.    I think the unique_file() function was originally meant for just temp files, hence the 0600 permissions.   The other part of my patch is a function to flip on the 'x' bit on any file.
>>> 
>>> Sure, that works for me as well. :)
>> 
>> To clarify a bit here:
>> 
>> Yes, I believe that unique_file was originally meant for just temp files, unfortunately it's been pressed into service everywhere. The interface that you're working on would be excellent to replace all but the temp file usage throughout llvm so I'm fine with this going away at that point.
> 
> Looks like clang has already adopted the new "mode" parameter, so changing will be a little more complicated.

Not really. It just means the patch removing the parameter will need to be put into the tree at the same time as the one to remove the use. The c++ api is not stable, nor is guaranteed to be.

-eric