[llvm-commits] [PATCH] Teach SimplifyLibCalls about stpcpy

Chad Rosier mcrosier at apple.com
Mon May 14 09:36:19 PDT 2012


David,
Just a few minor points.

+
 //===---------------------------------------===//
+// 'stpcpy' Optimizations

No need for the extra white-space above the comments.

+    StrCpyOpt StrCpy; StrCpyOpt StrCpyChk; StpCpyOpt StpCpy; StpCpyOpt StpCpyChk;

80-column violation.

+
+//===---------------------------------------===//
 // 'strncpy' Optimizations

No need for the extra white-space above the comments.

+
 //===---------------------------------------===//
 // 'strlen' Optimizations

Same.

Otherwise, LGTM.

 Chad

On May 13, 2012, at 4:52 PM, David Majnemer wrote:

> Hello,
> 
> The attached patch converts stpcpy(x, "some_litteral") into a memcpy
> and a GetElementPointer instruction.
> 
> -- 
> David Majnemer
> <simplify_stpcpy.patch>_______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits




More information about the llvm-commits mailing list