[llvm-commits] [PATCH][LNT] Add support for selection of timing statistic (user or real time)

[David Blaikie]

Ping.

On Sun, Apr 29, 2012 at 9:43 PM, David Blaikie <dblaikie at gmail.com> wrote:
> Bump.
>
> On Mon, Apr 23, 2012 at 4:26 PM, David Blaikie <dblaikie at gmail.com> wrote:
>> Hi Daniel (& others),
>>
>> Here's a couple of patches that add an option to the LNT nt runner to
>> allow the selection of statistic to report (user time or real time) &
>> includes the necessary plumbing through the test-suite to propagate
>> this information (rather than passing a flag down through the
>> test-suite strata, this elevates both stats (we could add sys time for
>> symmetry at some point - and/or, more broadly, we could also stop
>> doing the aggregation (of multisource per-file stats into single
>> per-test stats) down in the test-suite & let LNT have more fine
>> grained information about the sub-parts of a test case's timing) up
>> into the simple report.
>>
>> [I removed one instance of the 'summary' parsing in timeit.c - it
>> seems there were two instances of it. If there's a reason for the
>> apparent duplication I'd love to hear it - then add it back in with a
>> comment explaining that. I also removed the 'program' timing there -
>> the reports currently can just deliberately pick which statistics they
>> want. It seems like only the nightly and simple reports were using
>> these values, so I've updated those. I was wondering if I could also
>> remove the 'exit' lines so the summaries just look like time(1)
>> output, but I haven't got there yet - the exit lines are used from
>> these files in some places. Perhaps there are other sources they could
>> use instead]
>>
>> Anyone have some thoughts on this approach or future work along these lines?
>>
>> - David
-------------- next part --------------
A non-text attachment was scrubbed...
Name: lnt-time-stat.diff
Type: application/octet-stream
Size: 2642 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120514/35ce6823/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: test-suite-time-stat.diff
Type: application/octet-stream
Size: 6895 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120514/35ce6823/attachment-0001.obj>