[llvm-commits] [RFC] Patch 1/3 for the native code compiler of Erlang

[Jakob Stoklund Olesen]

On May 13, 2012, at 8:32 AM, Yiannis Tsiouris wrote:

> On 05/09/2012 11:14 AM, Yiannis Tsiouris wrote:
>> On 05/08/2012 10:57 PM, Jakob Stoklund Olesen wrote:
>>> 
>>> You need to use ptr_rc_tailcall instead of GR32_TC in those instruction definitions. That is how getPointerRegClass() gets called.
>>> 
>>> /jakob
>> Thanks for your help Jakob,
>> 
>> I attach an updated version of the HiPE CC patch.
>> 
> Ping.
> 
> Is there anything wrong with this patch?

The patch doesn't apply cleanly, possibly because of the missing newline at the end of your test case.

Here you check for a NULL Function:

     const Function *F = MF->getFunction();                                      
     ghcCall = (F ? F->getCallingConv() == CallingConv::GHC : false);            
+    hipeCall = (F ? F->getCallingConv() == CallingConv::HiPE : false);          

Here you don't:

+    if (MF.getFunction()->getCallingConv() == CallingConv::HiPE)                
+      return &X86::GR32RegClass;                                                

/jakob