[llvm-commits] [llvm] r156658 - /llvm/trunk/lib/CodeGen/SelectionDAG/FastISel.cpp

[Chad Rosier]

On May 11, 2012, at 4:18 PM, Eli Friedman wrote:

> On Fri, May 11, 2012 at 4:14 PM, Chad Rosier <mcrosier at apple.com> wrote:
>> Or rather, unoptimized compiles don't use the expect intrinsic.
> 
> I don't think we can just ignore it, though... the result of this
> intrinsic generally does get used.

Yup, you're totally right.  Reverted in revision 156662.

> -Eli
> 
>> 
>>  Chad
>> 
>> On May 11, 2012, at 4:10 PM, Chad Rosier wrote:
>> 
>>> Author: mcrosier
>>> Date: Fri May 11 18:10:58 2012
>>> New Revision: 156658
>>> 
>>> URL: http://llvm.org/viewvc/llvm-project?rev=156658&view=rev
>>> Log:
>>> [fast-isel] Fast-isel doesn't use the expect intrinsic.
>>> 
>>> Modified:
>>>    llvm/trunk/lib/CodeGen/SelectionDAG/FastISel.cpp
>>> 
>>> Modified: llvm/trunk/lib/CodeGen/SelectionDAG/FastISel.cpp
>>> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/SelectionDAG/FastISel.cpp?rev=156658&r1=156657&r2=156658&view=diff
>>> ==============================================================================
>>> --- llvm/trunk/lib/CodeGen/SelectionDAG/FastISel.cpp (original)
>>> +++ llvm/trunk/lib/CodeGen/SelectionDAG/FastISel.cpp Fri May 11 18:10:58 2012
>>> @@ -570,9 +570,10 @@
>>>   // Handle selected intrinsic function calls.
>>>   switch (F->getIntrinsicID()) {
>>>   default: break;
>>> -    // At -O0 we don't care about the lifetime intrinsics.
>>> +    // At -O0 we don't care about the lifetime or expect intrinsics.
>>>   case Intrinsic::lifetime_start:
>>>   case Intrinsic::lifetime_end:
>>> +  case Intrinsic::expect:
>>>     return true;
>>>   case Intrinsic::dbg_declare: {
>>>     const DbgDeclareInst *DI = cast<DbgDeclareInst>(Call);
>>> 
>>> 
>>> _______________________________________________
>>> llvm-commits mailing list
>>> llvm-commits at cs.uiuc.edu
>>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>> 
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits