[llvm-commits] [PATCH] llvm-c dump IL to file

[Hans Wennborg]

On Wed, May 9, 2012 at 3:51 PM, Carlo Kok <ck at remobjects.com> wrote:
> Op 5/9/2012 3:12 PM, Hans Wennborg schreef:
>> On Tue, May 8, 2012 at 8:51 PM, Carlo Kok<ck at remobjects.com>  wrote:
>>> This copy pattern is used pretty much through all of llvm-c.  The caller
>>> would then have to call LLVMDisposeMessage to get rid of the memory.
>> Yup, that's the way I understand it too.
>>
>> Just one more thing I came to think of: it would be great if the
>> comment in the header file could mention what the return values from
>> LLVMPrintModuleToFile mean.
>>
>> I'd be happy to land this for you unless someone has additional comments.
>
> cool.
>
>
> As for the result, FALSE = "it's oke", TRUE is "an error occured". This
> matches all the other functions in llvm-c with LLVMBool. You want me to
> post a new patch with this in the description?

I added it to the comment and landed in r156479.

Thanks,
Hans