[llvm-commits] [cfe-commits] [PATCH] Make solution folders optional in cmake

[Manuel Klimek]

On Wed, May 9, 2012 at 4:20 PM, Douglas Gregor <dgregor at apple.com> wrote:
> Still LGTM, but now a question: does CMake expose the target VS version, so that we could just do the right thing rather than making the user poke at an option?

Unfortunately not. I tried to find a way yesterday, until I hit:
http://www.cmake.org/pipermail/cmake/2011-May/044417.html
which explains that cmake's build has such an option itself because
there is no good way :(

Cheers,
/Manuel

>
> Sent from my iPhone
>
> On May 8, 2012, at 11:58 PM, Manuel Klimek <klimek at google.com> wrote:
>
>> +llvm-commits
>>
>> On Wed, May 9, 2012 at 8:34 AM, Douglas Gregor <dgregor at apple.com> wrote:
>>> LGTM
>>
>> Whoops, just noticed that this is a top-level llvm change and I only
>> sent it to cfe-commits :) Want to make sure the LGTM still counts in
>> that case...
>>
>> Thanks!
>> /Manuel
>>
>>>
>>> Sent from my iPhone
>>>
>>> On May 8, 2012, at 12:06 PM, Manuel Klimek <klimek at google.com> wrote:
>>>
>>>> Using cmake with VS 2010 Express is a pain, as it doesn't support
>>>> solution folders. This patch allows easily turning them off for
>>>> express users.
>>>>
>>>> Thoughts?
>>>> /Manuel
>>>>
>>>> Index: CMakeLists.txt
>>>> ===================================================================
>>>> --- CMakeLists.txt    (revision 156387)
>>>> +++ CMakeLists.txt    (working copy)
>>>> @@ -15,7 +15,10 @@
>>>>
>>>> set(PACKAGE_VERSION "${LLVM_VERSION_MAJOR}.${LLVM_VERSION_MINOR}svn")
>>>>
>>>> -set_property(GLOBAL PROPERTY USE_FOLDERS ON)
>>>> +option(LLVM_USE_FOLDERS "Enable solution folders in Visual Studio.
>>>> Disable for Express versions." ON)
>>>> +if ( LLVM_USE_FOLDERS )
>>>> +  set_property(GLOBAL PROPERTY USE_FOLDERS ON)
>>>> +endif()
>>>>
>>>> include(VersionFromVCS)
>>>> _______________________________________________
>>>> cfe-commits mailing list
>>>> cfe-commits at cs.uiuc.edu
>>>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits