[llvm-commits] [llvm] [Patch] Add RuntimeDyld.invalidateEmittedSectionsCache()

[Jim Grosbach]

Hi Danil,

This is closer, but not quite. By the client's memory manager, I mean the application. This functionality shouldn't be in the core MC-JIT at all. For example, it belongs in the TrivialMemoryManager in llvm-rtdyld.cpp. That includes keeping the list of allocations and sections. Consider a remote client. The MemoryBlock map you're creating here will refer to the local copy, not the memory that's actually on the target where it'll be executed. The code that knows how to map between the two is the client's memory manager, so that's where this logic belongs as well.

-Jim

On May 8, 2012, at 4:09 PM, Danil Malyshev <dmalyshev at accesssoftek.com> wrote:

> Hi,
>  
> Please review changed the patch.
> This patch adds finalize() to RTDyldMemoryManager, and implements it for MCJITMemoryManager as invalidate instruction cache.
>  
>  
> Regards,
> Danil
>  
>  
> From: Jim Grosbach [grosbach at apple.com]
> Sent: Monday, May 07, 2012 4:16 PM
> To: Danil Malyshev
> Cc: llvm-commits at cs.uiuc.edu
> Subject: Re: [llvm-commits] [llvm] [Patch] Add RuntimeDyld.invalidateEmittedSectionsCache()
> 
> Hi Danil,
> 
> That's not the RuntimeDyld's job. That functionality belongs in elsewhere, probably in the client's memory manager implementation where it's hooked into copying the compiled code into the target's address space. For a hosted platform, something similar just w/o the copying.
> 
> -Jim
> 
> On May 7, 2012, at 2:09 PM, Danil Malyshev <dmalyshev at accesssoftek.com> wrote:
> 
>> Hi everyone,
>>  
>> Please review attached the patch.
>> This patch adds invalidateEmmittedSectionsCache() to the RuntimeDyld and uses it in the MCJIT after resolve relocations.
>> The MCJIT works unstable on the ARM platforms without it.
>> This patch haven't any tests because I want to commit the common ExecutionEngine/MCJIT tests after attached the patch will be committed. These tests will cover it.
>> Regards,
>> Danil
>> <RuntimeDyld_invalidateEmittedSectionsCache-01.patch>_______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
> 
> <RTDyldMemoryManager_finalize-01.patch>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120508/a07eae54/attachment.html>