[llvm-commits] [llvm] r156150 - /llvm/trunk/cmake/modules/HandleLLVMOptions.cmake

[Tom Care]

Perhaps we could check the value of CMAKE_GENERATOR and add the flag for Ninja only, since it seems to be the exception. If we start to need this change for multiple generators, we can try come up with a more general solution. I don't see an obvious general solution though, having looked at http://www.cmake.org/Wiki/CMake_Useful_Variables.

Tom

On 07/05/2012, at 11:20 PM, Rafael Espíndola wrote:

>> seemed to work for me for both values. Can you double check it doesn't work for you when toggling CMAKE_COLOR_MAKEFILE between OFF and ON?
> 
> OK, I found the problem. CMAKE_COLOR_MAKEFILE is only defined when
> producing Makefiles, so it fails with -G Ninja. In there a way to
> check what is the build file format cmake is generating?
> 
>> Thanks
>> 
>> Tom
> 
> Cheers,
> Rafael
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120509/f28b0db4/attachment.html>