[llvm-commits] [llvm] [Patch] Add RuntimeDyld.invalidateEmittedSectionsCache()

[Danil Malyshev]

Hi Jim,

So, it's looks like virtual emitSections() in the RTDyldMemoryManager, and implementation in the MCJITMemoryManager as clear cache for sections. The only thing I do not like the name emitSections(), it's will not correspond MCJITMemoryManager implementation, but I cannot find more closely name.
If its ok for you, I'll change the patch soon.


Regards,
Danil

________________________________
From: Jim Grosbach [grosbach at apple.com]
Sent: Monday, May 07, 2012 4:16 PM
To: Danil Malyshev
Cc: llvm-commits at cs.uiuc.edu
Subject: Re: [llvm-commits] [llvm] [Patch] Add RuntimeDyld.invalidateEmittedSectionsCache()

Hi Danil,

That's not the RuntimeDyld's job. That functionality belongs in elsewhere, probably in the client's memory manager implementation where it's hooked into copying the compiled code into the target's address space. For a hosted platform, something similar just w/o the copying.

-Jim

On May 7, 2012, at 2:09 PM, Danil Malyshev <dmalyshev at accesssoftek.com<mailto:dmalyshev at accesssoftek.com>> wrote:

Hi everyone,



Please review attached the patch.
This patch adds invalidateEmmittedSectionsCache() to the RuntimeDyld and uses it in the MCJIT after resolve relocations.
The MCJIT works unstable on the ARM platforms without it.
This patch haven't any tests because I want to commit the common ExecutionEngine/MCJIT tests after attached the patch will be committed. These tests will cover it.
Regards,
Danil
<RuntimeDyld_invalidateEmittedSectionsCache-01.patch>_______________________________________________
llvm-commits mailing list
llvm-commits at cs.uiuc.edu<mailto:llvm-commits at cs.uiuc.edu>
http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120507/29b254c9/attachment.html>