[llvm-commits] [PATCH] Add an MF pointer argument to TRI::getPointerRegClass and TII::getRegClass

[Jakob Stoklund Olesen]

On May 7, 2012, at 2:34 PM, Yiannis Tsiouris <gtsiour at softlab.ntua.gr> wrote:

> Hi Jakob,
> 
> On 05/07/2012 09:12 PM, Jakob Stoklund Olesen wrote:
>> 
>> You have some 80-col violations. Otherwise it looks good.
>> 
>> $ egrep '^\+ .{80}' getPointerRegClass-getRegClass-add-MF-arg.diff 
>> +        if (const TargetRegisterClass *DRC = TII->getRegClass(MCID,MONum,TRI,*MF)) {
>> +        if (const TargetRegisterClass *DRC = TII->getRegClass(MCID,MONum,TRI,*MF)) {
>> +      DstRC = TRI->getAllocatableClass(TII->getRegClass(*II, IIOpNum, TRI, *MF));
>> +                                                                          const {
>> +  unsigned TmpReg = MRI->createVirtualRegister(TII->getRegClass(MCID1,0,TRI,MF));
>> 
>> /jakob
> Should have been fixed in the attached!
> Thanks for taking some time to review this!

Committed r156328

> I'll resend a patch for HiPE Calling Convention as soon as I get some
> time to fix it!

When you do, please share a CalleeSavedRegs def with the GHC calling convention. There is only one way of having no callee-saved registers.

/jakob