[llvm-commits] [llvm] r153425 - in /llvm/trunk: autoconf/m4/func_isinf.m4 autoconf/m4/huge_val.m4 configure projects/sample/Makefile.llvm.config.in projects/sample/Makefile.llvm.rules projects/sample/autoconf/configure.ac projects/sample/autoconf/m4/func_isinf.m4 projects/sample/autoconf/m4/huge_val.m4 projects/sample/configure

[Dimitry Andric]

On 2012-03-26 04:09, Eric Christopher wrote:
> Author: echristo
> Date: Sun Mar 25 21:09:01 2012
> New Revision: 153425
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=153425&view=rev
> Log:
> Add some fixes to the configure script  for isInf and add
> --enable-libcpp to projects/sample.
> 
> Patch by Dmitri Shubin with additional fixes by me.
...
> --- llvm/trunk/autoconf/m4/huge_val.m4 (original)
> +++ llvm/trunk/autoconf/m4/huge_val.m4 Sun Mar 25 21:09:01 2012
> @@ -6,7 +6,7 @@
>    AC_CACHE_CHECK([for HUGE_VAL sanity], [ac_cv_huge_val_sanity],[
>      AC_LANG_PUSH([C++])
>      ac_save_CXXFLAGS=$CXXFLAGS
> -    CXXFLAGS=-pedantic
> +    CXXFLAGS+=" -pedantic"
>      AC_RUN_IFELSE(
>        AC_LANG_PROGRAM(
>          [#include <math.h>],

Unfortunately, non-bash shells (BSD /bin/sh, Debian dash, etc) don't
recognize the += operator for variables, leading to warnings during
configure:

  checking for HUGE_VAL sanity... /share/dim/src/llvm/trunk/projects/sample/configure: CXXFLAGS+= -pedantic: not found
  yes

Please use the more portable construct:

  CXXFLAGS="$CXXFLAGS -pedantic"

instead.

Note, this also applies to the release_31 branch.