[llvm-commits] [PATCH] PR12696: Encode 'nonlazybind' and 'address_safety' properly in BitcodeWriter

Chris Lattner clattner at apple.com
Fri May 4 10:25:16 PDT 2012


On May 3, 2012, at 10:26 PM, Meador Inge wrote:

> Hi All,
> 
> This patch fixes PR12696 which reported that the BitcodeWriter was not
> encoding the
> 'nonlazybind' and 'address_safety' attributes correctly.  Alessandro
> Pignotti suggested
> the original patch.  I wrote the test case and regression tested the change.

This looks very close, but I don't like the magic numbers in the bitcode writer.  If there is no convenient enum in Attributes.h, can you add a new enum with the magic number there?

-Chris



More information about the llvm-commits mailing list