[llvm-commits] [PATCH] Make ARM and Mips use TargetMachine::getTLSModel()

[James Molloy]

FWIW, This LGTM.

I'm not sure if I'm qualified to sign off on patches though!

Cheers,

James

-----Original Message-----
From: llvm-commits-bounces at cs.uiuc.edu
[mailto:llvm-commits-bounces at cs.uiuc.edu] On Behalf Of Hans Wennborg
Sent: 01 May 2012 22:35
To: Eric Christopher
Cc: llvm-commits
Subject: Re: [llvm-commits] [PATCH] Make ARM and Mips use
TargetMachine::getTLSModel()

On Tue, May 1, 2012 at 7:49 PM, Eric Christopher <echristo at apple.com> wrote:
>
> On May 1, 2012, at 9:55 AM, Hans Wennborg <hans at chromium.org> wrote:
>
>> On Fri, Apr 27, 2012 at 19:00, Hans Wennborg <hans at chromium.org> wrote:
>>> Hi all,
>>>
>>> The attached patch moves the logic for selecting a TLS model to a single
place,
>>> instead of the previous three (ARM, Mips, and X86 which already
>>> uses this function).
>>>
>>> Please take a look.
>>>
>>> Thanks,
>>> Hans
>>
>> Ping?
>
> Can you ping with the patch? :)

Sure; patch now attached.

 - Hans