[llvm-commits] PATCH: Fix non-deterministic debug info output for C++ inputs

Chandler Carruth chandlerc at gmail.com
Wed May 2 22:19:17 PDT 2012


On Wed, May 2, 2012 at 10:10 PM, Bendersky, Eli <eli.bendersky at intel.com>wrote:

>  I looked at the FoldingSetVector implementation and LGTM with tiny nits:*
> ***
>
> **1.       **Typo s/interator/iterator/
>
Thanks, fixed.


> ****
>
> **2.       **Is there any special reason to put “SelfT tmp = *this;
> ++*this; return tmp;” all on the same line?
>
I based it on surrounding code for iterators where its all on one line. I
don't really care either way.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120502/f977a10c/attachment.html>


More information about the llvm-commits mailing list