[llvm-commits] Please review: /llvm/trunk: include/llvm/CodeGen/DFAPacketizer.h lib/CodeGen/DFAPacketizer.cpp

[Andrew Trick]

On Apr 25, 2012, at 11:36 AM, Sirish Pande <spande at codeaurora.org> wrote:

> Hi Andy,
> 
> I tried using MISUnits map but  it requires more work than I estimated - given that we use the map created in DFAPacketizer.cpp is used extensively in our HexagonVLIWPacketizer.cpp.
> So, I was wondering if I could just commit the patch with the map created in DFAPacketizer.cpp.  It still incorporates all the other suggestions that you have made.
> 
> I will have another patch down the line that will use your mapping functionality. I think another patch is good place for it because that patch will have some rework of DFAPacketizer as ScheduleDAGInstrs.h is in the include directory now.  In the rework of DFAPacketizer, we don't need to create an instance of DefaultVLIWScheduler in the ctor of VLIWPacketizerList. That will make things much simpler.
> 
> Let me know what you think. Also I have attached for your review.
> 
> <dfapacketizer.patch>


Sirish,

Go ahead and commit this.

But in your next set of changes please use MISUnitMap as intended. If it doesn't work for specialized schedulers, I need to understand why.

-Andy