[llvm-commits] [PATCH] Fix fastcc structure return with fast-isel on x86-32

[Derek Schuff]

ping!

On Mon, Apr 23, 2012 at 11:24 AM, Derek Schuff <dschuff at google.com> wrote:
> sorry, updated patch attached.
>
>
> On Thu, Apr 19, 2012 at 4:02 PM, Joerg Sonnenberger
> <joerg at britannica.bec.de> wrote:
>> On Thu, Apr 19, 2012 at 03:09:47PM -0700, Derek Schuff wrote:
>>> Hi all,
>>> on x86-32, structure return via sret lets the callee pop the hidden
>>> pointer argument off the stack, which the caller then re-pushes.
>>> However if the calling convention is fastcc, then a register is used
>>> instead, and the caller should not adjust the stack. This is
>>> implemented with a check of IsTailCallConvention
>>> X86TargetLowering::LowerCall  but is not checked properly in
>>> X86FastISel::DoSelectCall. The attached patch fixes that. Please
>>> review.
>>
>> Test case?
>>
>> Joerg
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits