[llvm-commits] [lld] Fix some warnings

Evandro Menezes emenezes at codeaurora.org
Wed Apr 25 12:41:03 PDT 2012


I noticed that LLD builds mostly cleanly, except for a some warnings, 
which this proposed patch aims to fix.

OK to commit?

-- 
Evandro Menezes          Austin, TX          emenezes at codeaurora.org
Qualcomm Innovation Center, Inc is a member of the Code Aurora Forum

-------------- next part --------------
Index: include/lld/Core/DefinedAtom.h
===================================================================
--- include/lld/Core/DefinedAtom.h	(revision 155577)
+++ include/lld/Core/DefinedAtom.h	(working copy)
@@ -151,7 +151,7 @@ class DefinedAtom : public Atom {
     typeTLVInitialZeroFill, // TLV initial zero fill data [Darwin]
     typeTLVInitializerPtr,  // pointer to thread local initializer [Darwin]
     typeFirstInSection,     // label for boundary of section [Darwin]
-    typeLastInSection,      // label for boundary of section [Darwin]
+    typeLastInSection       // label for boundary of section [Darwin]
   };
 
   enum ContentPermissions {
@@ -159,7 +159,7 @@ class DefinedAtom : public Atom {
     permR__  = 8,           // mapped read-only
     permR_X  = 8 + 2,       // mapped readable and executable
     permRW_  = 8 + 4,       // mapped readable and writable
-    permRW_L = 8 + 4 + 1,   // initially mapped r/w, then made read-only
+    permRW_L = 8 + 4 + 1    // initially mapped r/w, then made read-only
                             // loader writable
   };
 
Index: lib/Platforms/Darwin/ExecutableWriter.cpp
===================================================================
--- lib/Platforms/Darwin/ExecutableWriter.cpp	(revision 155577)
+++ lib/Platforms/Darwin/ExecutableWriter.cpp	(working copy)
@@ -1219,7 +1219,7 @@ void SymbolStringsChunk::computeSize(const lld::Fi
 uint32_t SymbolStringsChunk::stringIndex(StringRef str) {
   uint32_t result = _strings.size();
   const char* s = str.data();
-  for (int i=0; i < str.size(); ++i) {
+  for (unsigned int i=0; i < str.size(); ++i) {
     _strings.push_back(s[i]);
   }
   _strings.push_back('\0');
Index: lib/Platforms/Darwin/DarwinReferenceKinds.h
===================================================================
--- lib/Platforms/Darwin/DarwinReferenceKinds.h	(revision 155577)
+++ lib/Platforms/Darwin/DarwinReferenceKinds.h	(working copy)
@@ -31,7 +31,7 @@ class ReferenceKind {
     lazyTarget  = 6,
     lazyImm     = 7,
     gotTarget   = 8,
-    pointer64   = 9,
+    pointer64   = 9
   };
 
   static Reference::Kind fromString(StringRef kindName); 
Index: lib/Platforms/Darwin/MachOFormat.hpp
===================================================================
--- lib/Platforms/Darwin/MachOFormat.hpp	(revision 155577)
+++ lib/Platforms/Darwin/MachOFormat.hpp	(working copy)
@@ -119,7 +119,7 @@ enum {
   VM_PROT_NONE    = 0x0,
   VM_PROT_READ    = 0x1,
   VM_PROT_WRITE   = 0x2,
-  VM_PROT_EXECUTE = 0x4,
+  VM_PROT_EXECUTE = 0x4
 };
 
 
Index: lib/Core/NativeFileFormat.h
===================================================================
--- lib/Core/NativeFileFormat.h	(revision 155577)
+++ lib/Core/NativeFileFormat.h	(working copy)
@@ -97,7 +97,7 @@ enum NativeChunkSignatures {
   NCS_ReferencesArrayV2 = 8,
   NCS_TargetsTable = 9,
   NCS_AddendsTable = 10,
-  NCS_Content = 11,
+  NCS_Content = 11
 };
 
 //
@@ -121,7 +121,7 @@ enum {
   NFA_x86     = 1,
   NFA_x86_64  = 2,
   NFA_armv6   = 3,
-  NFA_armv7   = 4,
+  NFA_armv7   = 4
 };
 
 


More information about the llvm-commits mailing list