[llvm-commits] [llvm] r155464 - in /llvm/trunk/include/llvm: CRSBuilder.h ConstantRangesSet.h

[Stepan Dyatkovskiy]

Chandler Carruth wrote:
> On Tue, Apr 24, 2012 at 11:31 AM, Stepan Dyatkovskiy <stpworld at narod.ru
> <mailto:stpworld at narod.ru>> wrote:
>
>     Related to PR1255. Let's begin. I'll commit classes that corresponds
>     to our latest PR1255 discussion posts in llvm-commits.
>
>
> Why are these being directly committed instead of posted to that
> discussion for review? This is definitely non-trivial and non-obvious,
> it should be reviewed before commit.

Hi Chandler,

Huh... It was discussed very long long time (since autumn 2011). Current 
thread is called "New classes for PR1255: Should enhance LLVM switch 
instruction to take case ranges."

My last proposal was here:
http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20120305/138780.html

Here Chris said that it looks sensible to him:
http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20120319/139265.html

After long pause I decided to commit classes at your own risk; since it 
just a new classes, and it doesn't broke/affect anything. Now these 
classes in svn, and people can easy access to actual state of PR1255; 
they also can send remarks, and they can watch history of changes.
Anyway I'll watch for buildbots.

...And if community found these classes absolutely bad (but I hope not), 
of course I'll reject it.

-Stepan.