[llvm-commits] [llvm] r155468 - in /llvm/trunk: lib/Transforms/InstCombine/InstCombineCalls.cpp test/Transforms/InstCombine/2012-04-23-Neon-Intrinsics.ll

[Chris Lattner]

On Apr 24, 2012, at 3:10 PM, Lang Hames wrote:

> Hi Chandler,
>  
> I'm not sure what you mean by "the right size" here? the vmull_n_* intrinsic parameters are always half the width of its result, so they'll never be "the right size" by that measure. I'll try deferring the simplification though - that might be a win.
> 
> No such luck - deferring simplification of the ext instructions causes this to miss a lot of opportunities.
>  
> Will be OOO for the next hour or so. Hopefully I'll catch you when I get back.

Hi Lang,

I think the best thing to do is to revert this patch until we can work out a solution that works.  We really don't like instcombine code that "creates some IR, then sees if it can simplify, if not remove it", as we talked about these evening.

-Chris

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120424/682b4b0d/attachment.html>