[llvm-commits] [llvm] r155226 - /llvm/trunk/lib/CodeGen/ScheduleDAGInstrs.cpp

[Andrew Trick]

Always willing to improve comments: r155229
-Andy

On Apr 20, 2012, at 1:14 PM, Chad Rosier <mcrosier at apple.com> wrote:

> Andy,
> 
> On Apr 20, 2012, at 1:05 PM, Andrew Trick wrote:
> 
>> Author: atrick
>> Date: Fri Apr 20 15:05:21 2012
>> New Revision: 155226
>> 
>> URL: http://llvm.org/viewvc/llvm-project?rev=155226&view=rev
>> Log:
>> misched: initialize BB
>> 
>> Modified:
>>   llvm/trunk/lib/CodeGen/ScheduleDAGInstrs.cpp
>> 
>> Modified: llvm/trunk/lib/CodeGen/ScheduleDAGInstrs.cpp
>> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/ScheduleDAGInstrs.cpp?rev=155226&r1=155225&r2=155226&view=diff
>> ==============================================================================
>> --- llvm/trunk/lib/CodeGen/ScheduleDAGInstrs.cpp (original)
>> +++ llvm/trunk/lib/CodeGen/ScheduleDAGInstrs.cpp Fri Apr 20 15:05:21 2012
>> @@ -126,7 +126,8 @@
>>  return 0;
>> }
>> 
>> -void ScheduleDAGInstrs::startBlock(MachineBasicBlock *BB) {
>> +void ScheduleDAGInstrs::startBlock(MachineBasicBlock *bb) {
>> +  BB = bb;
>>  LoopRegs.Deps.clear();
>>  if (MachineLoop *ML = MLI.getLoopFor(BB))
>>    if (BB == ML->getLoopLatch())
>> @@ -134,6 +135,7 @@
>> }
>> 
>> void ScheduleDAGInstrs::finishBlock() {
>> +  BB = 0;
>>  // Nothing to do.
> 
> Seems you're doing something.. ;)
> 
> Chad
> 
>> }
>> @@ -159,7 +161,7 @@
>>                                    MachineBasicBlock::iterator begin,
>>                                    MachineBasicBlock::iterator end,
>>                                    unsigned endcount) {
>> -  BB = bb;
>> +  assert(bb == BB && "startBlock should set BB");
>>  RegionBegin = begin;
>>  RegionEnd = end;
>>  EndIndex = endcount;
>> 
>> 
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>