[llvm-commits] [PATCH] Fix fastcc structure return with fast-isel on x86-32

Joerg Sonnenberger joerg at britannica.bec.de
Thu Apr 19 16:02:52 PDT 2012


On Thu, Apr 19, 2012 at 03:09:47PM -0700, Derek Schuff wrote:
> Hi all,
> on x86-32, structure return via sret lets the callee pop the hidden
> pointer argument off the stack, which the caller then re-pushes.
> However if the calling convention is fastcc, then a register is used
> instead, and the caller should not adjust the stack. This is
> implemented with a check of IsTailCallConvention
> X86TargetLowering::LowerCall  but is not checked properly in
> X86FastISel::DoSelectCall. The attached patch fixes that. Please
> review.

Test case?

Joerg



More information about the llvm-commits mailing list