[llvm-commits] [llvm] r155047 - in /llvm/trunk: include/llvm/ include/llvm/CodeGen/ lib/CodeGen/ lib/Target/Hexagon/ lib/Target/Hexagon/InstPrinter/ lib/Target/Hexagon/MCTargetDesc/

[Sirish Pande]

Hi,

I sincerely apologize for causing the confusion and warnings from the 
Hexagon backend, will make sure something like this will not happen again.

We will fix the warnings, and resubmit the patches.

Sirish

On 4/18/2012 4:31 PM, Chandler Carruth wrote:
> Author: chandlerc
> Date: Wed Apr 18 16:31:19 2012
> New Revision: 155047
>
> URL: http://llvm.org/viewvc/llvm-project?rev=155047&view=rev
> Log:
> This reverts a long string of commits to the Hexagon backend. These
> commits have had several major issues pointed out in review, and those
> issues are not being addressed in a timely fashion. Furthermore, this
> was all committed leading up to the v3.1 branch, and we don't need piles
> of code with outstanding issues in the branch.
>
> It is possible that not all of these commits were necessary to revert to
> get us back to a green state, but I'm going to let the Hexagon
> maintainer sort that out. They can recommit, in order, after addressing
> the feedback.
>
> Reverted commits, with some notes:
>
> Primary commit r154616: HexagonPacketizer
>    - There are lots of review comments here. This is the primary reason
>      for reverting. In particular, it introduced large amount of warnings
>      due to a bad construct in tablegen.
>    - Follow-up commits that should be folded back into this when
>      reposting:
>      - r154622: CMake fixes
>      - r154660: Fix numerous build warnings in release builds.
>    - Please don't resubmit this until the three commits above are
>      included, and the issues in review addressed.
>
> Primary commit r154695: Pass to replace transfer/copy ...
>    - Reverted to minimize merge conflicts. I'm not aware of specific
>      issues with this patch.
>
> Primary commit r154703: New Value Jump.
>    - Primarily reverted due to merge conflicts.
>    - Follow-up commits that should be folded back into this when
>      reposting:
>      - r154703: Remove iostream usage
>      - r154758: Fix CMake builds
>      - r154759: Fix build warnings in release builds
>    - Please incorporate these fixes and and review feedback before
>      resubmitting.
>
> Primary commit r154829: Hexagon V5 (floating point) support.
>    - Primarily reverted due to merge conflicts.
>    - Follow-up commits that should be folded back into this when
>      reposting:
>      - r154841: Remove unused variable (fixing build warnings)
>
> There are also accompanying Clang commits that will be reverted for
> consistency.
>
> Removed:
>      llvm/trunk/lib/Target/Hexagon/HexagonCopyToCombine.cpp
>      llvm/trunk/lib/Target/Hexagon/HexagonInstrInfoV5.td
>      llvm/trunk/lib/Target/Hexagon/HexagonIntrinsicsV5.td
>      llvm/trunk/lib/Target/Hexagon/HexagonMCInst.h
>      llvm/trunk/lib/Target/Hexagon/HexagonNewValueJump.cpp
>      llvm/trunk/lib/Target/Hexagon/HexagonVLIWPacketizer.cpp
> Modified:
>      llvm/trunk/include/llvm/CodeGen/DFAPacketizer.h
>      llvm/trunk/include/llvm/IntrinsicsHexagon.td
>      llvm/trunk/lib/CodeGen/DFAPacketizer.cpp
>      llvm/trunk/lib/Target/Hexagon/CMakeLists.txt
>      llvm/trunk/lib/Target/Hexagon/Hexagon.h
>      llvm/trunk/lib/Target/Hexagon/HexagonAsmPrinter.cpp
>      llvm/trunk/lib/Target/Hexagon/HexagonCallingConv.td
>      llvm/trunk/lib/Target/Hexagon/HexagonExpandPredSpillCode.cpp
>      llvm/trunk/lib/Target/Hexagon/HexagonISelDAGToDAG.cpp
>      llvm/trunk/lib/Target/Hexagon/HexagonISelLowering.cpp
>      llvm/trunk/lib/Target/Hexagon/HexagonISelLowering.h
>      llvm/trunk/lib/Target/Hexagon/HexagonInstrFormats.td
>      llvm/trunk/lib/Target/Hexagon/HexagonInstrFormatsV4.td
>      llvm/trunk/lib/Target/Hexagon/HexagonInstrInfo.cpp
>      llvm/trunk/lib/Target/Hexagon/HexagonInstrInfo.h
>      llvm/trunk/lib/Target/Hexagon/HexagonInstrInfo.td
>      llvm/trunk/lib/Target/Hexagon/HexagonInstrInfoV3.td
>      llvm/trunk/lib/Target/Hexagon/HexagonInstrInfoV4.td
>      llvm/trunk/lib/Target/Hexagon/HexagonIntrinsics.td
>      llvm/trunk/lib/Target/Hexagon/HexagonIntrinsicsDerived.td
>      llvm/trunk/lib/Target/Hexagon/HexagonMCInstLower.cpp
>      llvm/trunk/lib/Target/Hexagon/HexagonRegisterInfo.cpp
>      llvm/trunk/lib/Target/Hexagon/HexagonRegisterInfo.td
>      llvm/trunk/lib/Target/Hexagon/HexagonSchedule.td
>      llvm/trunk/lib/Target/Hexagon/HexagonScheduleV4.td
>      llvm/trunk/lib/Target/Hexagon/HexagonSplitTFRCondSets.cpp
>      llvm/trunk/lib/Target/Hexagon/HexagonSubtarget.cpp
>      llvm/trunk/lib/Target/Hexagon/HexagonSubtarget.h
>      llvm/trunk/lib/Target/Hexagon/HexagonTargetMachine.cpp
>      llvm/trunk/lib/Target/Hexagon/InstPrinter/HexagonInstPrinter.cpp
>      llvm/trunk/lib/Target/Hexagon/InstPrinter/HexagonInstPrinter.h
>      llvm/trunk/lib/Target/Hexagon/MCTargetDesc/CMakeLists.txt
>      llvm/trunk/lib/Target/Hexagon/MCTargetDesc/HexagonBaseInfo.h
>
>

-- 
Qualcomm Innovation Center, Inc is a member of Code Aurora Forum