[llvm-commits] [llvm] r154908 - /llvm/trunk/test/CodeGen/X86/2011-09-14-valcoalesce.ll

[Andrew Trick]

On Apr 17, 2012, at 12:18 AM, Chandler Carruth <chandlerc at google.com> wrote:

> On Tue, Apr 17, 2012 at 8:20 AM, Andrew Trick <atrick at apple.com> wrote:
> Test cases that assume layout should use -disable-code-place.
> 
> Sorry for removing this is the interim...
> 
> However, did you verify that this test didn't in fact depend on the old code placement pass? That was something I found troubling during the cleanup -- several of the "don't assert" tests had loops in them that would have been moved around by it, making them not just sensitive to code placement, but potentially dependent on it...

This is not a good unit test. But it is very specific and brittle. If anything about the copies changes it breaks.

I dont care that you removed it. I think you did too much work trying to fix tests instead of disabling layout. 

Andy
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120417/55459398/attachment.html>