[llvm-commits] [llvm][PATCH][Review Requested] Maintain live-ins for anti-dependency checking

Anton Korobeynikov anton at korobeynikov.info
Mon Apr 16 11:20:35 PDT 2012


Hello, Preston

First, one minor nit-pick: please follow LLVM's code style (look into
surrounding code).
Next, register scavenger dependes heavily on correct register liveness
information. Given that X86 never had regscavenger enabled before, I'd
turn it for 3.2, not 3.1.
This will ensure that such really important change for important
target will be carefully tested and bugs (if any - though, for
example, 2.9 was not machine verifier clean on x86) will be fixed.
This is definitely not the last minute change.

-- 
With best regards, Anton Korobeynikov
Faculty of Mathematics and Mechanics, Saint Petersburg State University



More information about the llvm-commits mailing list