[llvm-commits] [llvm] r154811 - /llvm/trunk/include/llvm/Support/MDBuilder.h

[Chandler Carruth]

On Mon, Apr 16, 2012 at 3:21 PM, Duncan Sands <baldrick at free.fr> wrote:

> Add convenience methods to MDBuilder for attaching metadata to
> instructions,
> and retrieving it from instructions.  I don't have a use for this but is
> seems
> logical for it to exist.  While there, remove some 'const' markings from
> methods
> which are in fact 'const' in practice, but aren't logically 'const'.
>

I'm not really a fan of this interface.

If we want these convenience methods, they should be in Instruction, not on
MDBuilder. Fundamentally, MDBuilder should be a MD-producing entity, not an
IR-mutating entity.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120416/299dfddb/attachment.html>