[llvm-commits] DAG type Legalizer bug?

[Dan Gohman]

I'm not deeply familiar with that code, but the current code in
DisintegrateMERGE_VALUES does precisely what its doxygen comment
says it does, which suggest that it's not written that way by
accident.

Dan

On Apr 13, 2012, at 12:05 PM, Evan Cheng <evan.cheng at apple.com> wrote:

> Dan, can you review the patch?
> 
> Thanks,
> 
> Evan
> 
> On Apr 13, 2012, at 10:58 AM, "Guo, Xiaoyi" <Xiaoyi.Guo at amd.com> wrote:
> 
>> No, this has not been reviewed. I attached the patched again.
>>  
>> Thanks,
>> Xiaoyi
>>  
>> From: Evan Cheng [mailto:evan.cheng at apple.com] 
>> Sent: Thursday, April 12, 2012 10:27 PM
>> To: Guo, Xiaoyi
>> Cc: llvm-commits at cs.uiuc.edu
>> Subject: Re: [llvm-commits] DAG type Legalizer bug?
>>  
>> Has this been reviewed? Can you post the patch again?
>>  
>> Evan
>> 
>> On Apr 5, 2012, at 2:23 PM, "Guo, Xiaoyi" <Xiaoyi.Guo at amd.com> wrote:
>> 
>> Ping?
>>  
>> From: llvm-commits-bounces at cs.uiuc.edu [mailto:llvm-commits-bounces at cs.uiuc.edu] On Behalf OfGuo, Xiaoyi
>> Sent: Tuesday, April 03, 2012 11:39 AM
>> To: llvm-commits at cs.uiuc.edu
>> Subject: [llvm-commits] FW: DAG type Legalizer bug?
>>  
>> Please review the attached patch which fixes a bug as described below. Our test case fails on amdil backend. I failed to create a test case with one of the backends built-in to llvm. So I couldn’t add a test case to the unit test suite.
>>  
>> Thanks,
>> Xiaoyi
>>  
>> From: llvmdev-bounces at cs.uiuc.edu [mailto:llvmdev-bounces at cs.uiuc.edu] On Behalf Of Guo, Xiaoyi
>> Sent: Friday, March 23, 2012 8:11 PM
>> To: LLVM Developers Mailing List
>> Subject: [LLVMdev] DAG type Legalizer bug?
>>  
>> The following looks like a bug in the legalizer to me.
>>  
>> DAGTypeLegalizer::SplitRes_MERGE_VALUES(SDNode*N, unsigned ResNo, SDValue& Lo, SDValue& Hi) {
>>   SDValue Op = DisintegrateMERGE_VALUES(N, ResNo);
>>   GetSplitOp(Op, Lo, Hi);
>> }
>>  
>> DisintegrateMERGE_VALUE() returns SDValue(N, ResNo), where N is the MERGE_VALUE node itself.
>> Then GetSplitOp() tries to retrieve split result for N from the SplitVectors cache and hit assert because split result is for N is not in the cache yet.
>>  
>> Seems to me that DisintegrateMERGE_VALUES() should return the corresponding operand for the given ResNo, not the defined value.
>>  
>> Please confirm if it’s a bug, or if I’m missing something.
>>  
>> Thanks,
>> Xiaoyi
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>> <LegalizeTypes.patch>
>