[llvm-commits] [llvm] r154645 - /llvm/trunk/lib/Transforms/IPO/Internalize.cpp

[Bill Wendling]

On Apr 12, 2012, at 10:30 PM, Nick Lewycky wrote:

> Bill Wendling wrote:
>> Author: void
>> Date: Thu Apr 12 20:06:27 2012
>> New Revision: 154645
>> 
>> URL: http://llvm.org/viewvc/llvm-project?rev=154645&view=rev
>> Log:
>> Code-gen may inject code into the IR before it emits the ASM. The linker
>> obviously cannot know that this code is present, let alone used. So prevent the
>> internalize pass from internalizing those global values which code-gen may
>> insert.
> 
> This is a problem for other functions too, what about them?

It's their own fault!

;-)

> Could you use TargetLibraryInfo? If not, the best place would probably be an API to the backend. Anyhow, please move this to libLTO's applyScopeRestrictions at least. It doesn't belong here.
> 
I don't see why it shouldn't be here. Other implementations which use the Internalize pass don't necessarily need to use the LTO interface, but should have these symbols remain nonetheless.

-bw