[llvm-commits] ObjectFile / DataRefImpl constructor

[Danil Malyshev]

Committed at 154371, thank you!



Regards,

Danil


________________________________
From: Kaylor, Andrew [andrew.kaylor at intel.com]
Sent: Monday, April 09, 2012 1:06 PM
To: Danil Malyshev; llvm-commits at cs.uiuc.edu
Subject: RE: ObjectFile / DataRefImpl constructor

Looks good.

From: llvm-commits-bounces at cs.uiuc.edu [mailto:llvm-commits-bounces at cs.uiuc.edu] On Behalf Of Danil Malyshev
Sent: Thursday, April 05, 2012 5:22 PM
To: llvm-commits at cs.uiuc.edu
Subject: [llvm-commits] ObjectFile / DataRefImpl constructor

Hello everyone,

The DataRefImpl usually initialized with 0 after creation. If somewhere it will not be initialized, it's will have potential problem, for example:
DataRefImpl a, b;
a.p = 0;
b.p = 0;
if (a == b) // can be false for 32 bit platforms and always true for 64 bit.
Please review attached the patch, it's adds constructor for DataRefImpl and removes excess initialization.





Regards,

Danil

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120409/7e5e84fe/attachment.html>