[llvm-commits] [llvm] r154364 - in /llvm/trunk: lib/CodeGen/SelectionDAG/DAGCombiner.cpp test/CodeGen/Generic/pr12507.ll

Rafael Espindola rafael.espindola at gmail.com
Mon Apr 9 17:16:22 PDT 2012


Author: rafael
Date: Mon Apr  9 19:16:22 2012
New Revision: 154364

URL: http://llvm.org/viewvc/llvm-project?rev=154364&view=rev
Log:
Don't try to zExt just to check if an integer constant is zero, it might
not fit in a i64.

Added:
    llvm/trunk/test/CodeGen/Generic/pr12507.ll
Modified:
    llvm/trunk/lib/CodeGen/SelectionDAG/DAGCombiner.cpp

Modified: llvm/trunk/lib/CodeGen/SelectionDAG/DAGCombiner.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/SelectionDAG/DAGCombiner.cpp?rev=154364&r1=154363&r2=154364&view=diff
==============================================================================
--- llvm/trunk/lib/CodeGen/SelectionDAG/DAGCombiner.cpp (original)
+++ llvm/trunk/lib/CodeGen/SelectionDAG/DAGCombiner.cpp Mon Apr  9 19:16:22 2012
@@ -4431,9 +4431,9 @@
 
   ConstantSDNode *COp0 = dyn_cast<ConstantSDNode>(Op0);
   ConstantSDNode *COp1 = dyn_cast<ConstantSDNode>(Op1);
-  if (COp0 && COp0->getZExtValue() == 0)
+  if (COp0 && COp0->isNullValue())
     Op = Op1;
-  else if (COp1 && COp1->getZExtValue() == 0)
+  else if (COp1 && COp1->isNullValue())
     Op = Op0;
   else
     return false;

Added: llvm/trunk/test/CodeGen/Generic/pr12507.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/Generic/pr12507.ll?rev=154364&view=auto
==============================================================================
--- llvm/trunk/test/CodeGen/Generic/pr12507.ll (added)
+++ llvm/trunk/test/CodeGen/Generic/pr12507.ll Mon Apr  9 19:16:22 2012
@@ -0,0 +1,18 @@
+; RUN: llc < %s
+
+ at c = external global i32, align 4
+
+define void @foo(i160 %x) {
+entry:
+  %cmp.i = icmp ne i160 %x, 340282366920938463463374607431768211456
+  %conv.i = zext i1 %cmp.i to i32
+  %tobool.i = icmp eq i32 %conv.i, 0
+  br i1 %tobool.i, label %if.then.i, label %fn1.exit
+
+if.then.i:
+  store i32 0, i32* @c, align 4
+  br label %fn1.exit
+
+fn1.exit:
+  ret void
+}





More information about the llvm-commits mailing list