[llvm-commits] [PATCH] Fix PR12274 - bad EXTRACT_SUBREG in isel

[James Molloy]

Hi,

 

The attached patch fixes PR12274, an assertion failure firing when an ARM
NEON pattern is hit.

 

The bug is with code I submitted myself as part of the fix for PR11836 and
is trivial, so I don't know if I could have just committed without
pre-review. Perhaps someone could advise about that for the future?

 

The problem is the pattern creating an EXTRACT_SUBREG node from a Qreg
asking for a qsub_0, which I thought would be fine but apparently is not (I
didn't realise a no-op/identity extract_subreg like that would fail). My
original testcases also failed to cover it L

 

OK to commit?

 

Cheers,

 

James
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120405/ff643b7a/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pr12274.diff
Type: application/octet-stream
Size: 5847 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120405/ff643b7a/attachment.obj>