[llvm-commits] [PATCH] Review request - MCJIT runtime loader improvements

Danil Malyshev dmalyshev at accesssoftek.com
Wed Apr 4 18:19:38 PDT 2012


Hi Andrew,

It looks good for me, except using of "if ((bool)(err = ..." instead of "Check()", thank you!
But too fast growing number of isSectionXXX() in SectionRef. It would be better convert it to getFlags() as it was done in SymbolRef.





Regards,

Danil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120404/fdf3cf36/attachment.html>


More information about the llvm-commits mailing list