[llvm-commits] [llvm] r154007 - /llvm/trunk/lib/Transforms/Scalar/LoopUnrollPass.cpp

[Hongbin Zheng]

Hi,

On Wed, Apr 4, 2012 at 8:44 PM, Chandler Carruth <chandlerc at google.com> wrote:
> FWIW, I agree with you both: this was indeed in the "trivial" bucket, and it
> should have a test case. =D
>
> On Wed, Apr 4, 2012 at 2:24 PM, Hongbin Zheng <etherzhhb at gmail.com> wrote:
>>
>> I think here it should use
>>
>> Threshold = std::min(OptSizeUnrollThreshold, Threshold);
I think i mis-understand this, according to the comment,
OptSizeUnrollThreshold is only use when there is no explicit
-unroll-threshold, that means when we executing this statement,
Threshold is holding the default value of the threshold, i.e. 150,
which is always smaller than OptSizeUnrollThreshold.
When we do assign the threshold explicitly, this statement is not executed.

best regards
ether