[llvm-commits] [llvm] r154007 - /llvm/trunk/lib/Transforms/Scalar/LoopUnrollPass.cpp

Chandler Carruth chandlerc at google.com
Wed Apr 4 05:44:35 PDT 2012

FWIW, I agree with you both: this was indeed in the "trivial" bucket, and
it should have a test case. =D

On Wed, Apr 4, 2012 at 2:24 PM, Hongbin Zheng <etherzhhb at gmail.com> wrote:

> I think here it should use
> Threshold = std::min(OptSizeUnrollThreshold, Threshold);
> Otherwise users are not able unroll the loop with a threshold that is
> small than OptSizeUnrollThreshold for function with "OptimizeForSize"
> attribute option.
> We can also provide a command line option to allow users to assign the
> value of OptSizeUnrollThreshold.

These both make sense to me.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120404/7866153b/attachment.html>

More information about the llvm-commits mailing list