[llvm-commits] [PATCH] use FileCheck instead of grep (was Re: LIT cleanup phase #3 - remove usage of bash)

Jay Foad jay.foad at gmail.com
Wed Apr 4 03:46:57 PDT 2012

On 26 March 2012 09:50, Chandler Carruth <chandlerc at google.com> wrote:
> Just thought I'd point out that removing the use of 'grep' from the test
> suite has very significant benefits outside of any one platform.
> I regularly find regressions in LLVM where a 'not grep' pattern fails to
> match because the comments change in the output, leaving bugs and other
> problems undiagnosed. FileCheck-izing these tests is of significant long
> term maintenance value IMO.

Just to check I'm on the right track, does this patch look OK? It
converts a couple of small tests to use FileCheck instead of grep.
Tested with "make check".

-------------- next part --------------
A non-text attachment was scrubbed...
Name: filecheck.diff
Type: application/octet-stream
Size: 1257 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120404/308981d6/attachment.obj>

More information about the llvm-commits mailing list