[llvm-commits] [lld] r153912 - in /lld/trunk: include/lld/Core/AbsoluteAtom.h include/lld/Core/Atom.h include/lld/Core/DefinedAtom.h include/lld/Core/SharedLibraryAtom.h include/lld/Core/UndefinedAtom.h lib/Core/Resolver.cpp lib/Core/SymbolTable.

[Michael Spencer]

On Tue, Apr 3, 2012 at 5:12 AM, Chandler Carruth <chandlerc at google.com> wrote:
> On Tue, Apr 3, 2012 at 1:56 AM, Michael J. Spencer <bigcheesegs at gmail.com>
> wrote:
>>
>> --- lld/trunk/lib/Core/Resolver.cpp (original)
>> +++ lld/trunk/lib/Core/Resolver.cpp Mon Apr  2 18:56:36 2012
>> @@ -15,6 +15,7 @@
>>  #include "lld/Core/SymbolTable.h"
>>  #include "lld/Core/UndefinedAtom.h"
>>
>> +#include "llvm/Support/Casting.h"
>>  #include "llvm/Support/raw_ostream.h"
>>
>>  #include <algorithm>
>> @@ -33,7 +34,7 @@
>>     if ( _liveAtoms.count(atom) )
>>       return false;
>>    // don't remove if marked never-dead-strip
>> -    if ( const DefinedAtom* defAtom = atom->definedAtom() ) {
>> +    if (const DefinedAtom* defAtom = llvm::dyn_cast<DefinedAtom>(atom)) {
>
>
> Could we do something similar to what Clang does and provide an LLVM header
> that pulls a bunch of these *really* common types into the local
> namespace(s) for lld?
>
> It'd be nice to fix this earlier rather than later.

I was thinking about that... Thanks for the push, I'll do that soon.

- Michael Spencer