[llvm-commits] [LLVM] [MC Disassembler] Addding support for dissassembler for MIPS

[Akira Hatanaka]

r153924.

2012/3/30 Medic, Vladimir <vmedic at mips.com>:
> Hi everyone,
> here is an updated patch that adds support for MIPS Disassembler. Comments are welcome.
> ________________________________________
> From: Rafael Espíndola [rafael.espindola at gmail.com]
> Sent: Wednesday, March 21, 2012 4:57 PM
> To: Medic, Vladimir
> Cc: llvm-commits at cs.uiuc.edu; Jovanovic, Petar; Jim Grosbach
> Subject: Re: [llvm-commits] [LLVM] [MC Disassembler] Addding support for dissassembler for MIPS
>
> On 16 March 2012 11:45, Medic, Vladimir <vmedic at mips.com> wrote:
>> Hi everyone,
>> here is a patch that adds support for MIPS Disassembler. Comments are
>> welcome.
>
> First of all, thanks for doing this and for all the tests!
>
> Nits:
>
>> +
>  > // Mips Pseudo Instructions Format
>
> Do you want the extra line?
>
>
> +  std::string TheTriple;
>
> This can be a StringRef, no?
>
> Given https://groups.google.com/group/llvm-dev/msg/d5c2be88fb5d0f1e ,
> can you use isPseudo instead of isCodeGenOnly?
>
> Cheers,
> Rafael
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>