[llvm-commits] [compiler-rt] r153735 - /compiler-rt/trunk/lib/atomic.c

[Chandler Carruth]

On Sat, Mar 31, 2012 at 2:22 AM, David Chisnall <csdavec at swan.ac.uk> wrote:

> On 31 Mar 2012, at 10:20, Chandler Carruth wrote:
>
> > On Fri, Mar 30, 2012 at 3:45 PM, Chandler Carruth <chandlerc at google.com>
> wrote:
> > On Fri, Mar 30, 2012 at 5:46 AM, David Chisnall <csdavec at swan.ac.uk>
> wrote:
> > I can disable that if __LP64__ is not defined, but I think a better
> solution would be for clang to support __uint128_t in 32-bit mode...
> >
> > David, please revert this patch and discuss this on the mailing list
> until these issues are addressed. This is why we have pre-commit review.
> >
> > David has clarified that review did take place, but apparantly off-list.
> =/ I wish that weren't happening.
> >
> > Anyways, could we at least disable this temporarily? Leaving the build
> broken isn't reasonable...
>
> If you read the bug report and check the commit log, you'll see that the
> __uint128_t case was disabled yesterday, fixing the build on 32-bit
> platforms...
>

Ah, thanks. I missed that commit. My apologies, I had just flagged this
thread to follow and not checked for other threads that might be relevant.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120331/f3fed4c6/attachment.html>