[llvm-commits] [patch]Fix for TableGen decoder generator

[David Blaikie]

On Fri, Mar 30, 2012 at 2:04 AM, Silviu Baranga <silbar01 at arm.com> wrote:
> Hi,
>
>
>
> TableGen's decoder generator does not add a break in the switch statements
> for decoding structure's leaf nodes, because it considers that the leaf
> nodes will always exit with a return. This is however not true for some
> backends (for example the ARM backend) where we have to match multiple
> architectures and an 'if' statement is generated to guard the leaf node.
>
>
>
> When failing the architecture check, without the break statement, the
> decoder will incorrectly fall through to the next branch and match other
> instructions that do  not correspond to the input bitpattern.
>
>
>
> The attached patch fixes this by making TableGen always emit a break
> statement for leaf nodes.

Do you have a test case for the bug that exposed this?

>
>
>
> Please review this patch.
>
>
>
> Thanks,
>
> Silviu
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>