[llvm-commits] [pr1225] Fix using instcombine instead of instsimplify
Rafael Espíndola
rafael.espindola at gmail.com
Wed Mar 28 19:15:44 PDT 2012
> My primary concern here is that this could introduce miscompiles
> because some callers of ComputeMaskedBits or SimplifyDemanded might
> get confused by seeing bits it didn't request/expect, like the issue I
> fixed in r152066. The concept of the patch seems fine, though.
Yes, I had to fix that pr in different way in this patch. That is why
I gave it the extra level of testing.
I will try building firefox with it too. Any other suggestions?
> -Eli
Cheers,
Rafael
More information about the llvm-commits
mailing list