[llvm-commits] [llvm] r153519 - /llvm/trunk/lib/Target/ARM/ARMLoadStoreOptimizer.cpp

[Evan Cheng]

Ugh. Are you sure? Thumb2SizeReduction pass needs liveness info.

Evan

On Mar 27, 2012, at 10:33 AM, Jakob Stoklund Olesen <stoklund at 2pi.dk> wrote:

> Author: stoklund
> Date: Tue Mar 27 12:33:52 2012
> New Revision: 153519
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=153519&view=rev
> Log:
> ARMLoadStoreOptimizer invalidates register liveness.
> 
> This pass tries to update kill flags, but there are still many bugs.
> Passes after the load/store optimizer don't need accurate liveness, so
> don't even try.
> 
> <rdar://problem/11101911>
> 
> Modified:
>    llvm/trunk/lib/Target/ARM/ARMLoadStoreOptimizer.cpp
> 
> Modified: llvm/trunk/lib/Target/ARM/ARMLoadStoreOptimizer.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/ARM/ARMLoadStoreOptimizer.cpp?rev=153519&r1=153518&r2=153519&view=diff
> ==============================================================================
> --- llvm/trunk/lib/Target/ARM/ARMLoadStoreOptimizer.cpp (original)
> +++ llvm/trunk/lib/Target/ARM/ARMLoadStoreOptimizer.cpp Tue Mar 27 12:33:52 2012
> @@ -1411,6 +1411,10 @@
>   }
> 
>   delete RS;
> +
> +  // Kill flags aren't updated accurately by this pass.
> +  Fn.getRegInfo().invalidateLiveness();
> +
>   return Modified;
> }
> 
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits