[llvm-commits] [PATCH] LIT cleanup phase #3 - remove usage of bash

Jim Grosbach grosbach at apple.com
Mon Mar 26 09:53:08 PDT 2012


On Mar 26, 2012, at 1:50 AM, Chandler Carruth <chandlerc at google.com> wrote:

> On Mon, Mar 26, 2012 at 1:46 AM, NAKAMURA Takumi <geek4civic at gmail.com> wrote:
> Rewrite MSYS-incompatible tests not to use grep.
> 
> Just thought I'd point out that removing the use of 'grep' from the test suite has very significant benefits outside of any one platform.
> 
> I regularly find regressions in LLVM where a 'not grep' pattern fails to match because the comments change in the output, leaving bugs and other problems undiagnosed. FileCheck-izing these tests is of significant long term maintenance value IMO.

+1

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120326/626fbb71/attachment.html>


More information about the llvm-commits mailing list