[llvm-commits] [PATCH] ARM: conditional BL should use fixup_arm_condbranch

[Måns Rullgård]

Tim Northover <Tim.Northover at arm.com> writes:

> On Friday 23 Mar 2012 00:04:52 Måns Rullgård wrote:
>> By using the same fixup kind for both, the distinction is lost in the
>> object writers.  Perhaps adding another fixup kind for conditional calls
>> (fixup_arm_condbl?) would be a solution.  The Mach-o writer could handle
>> this identically to fixup_arm_bl, while the ELF writer would select the
>> appropriate relocation type.  To me this seems cleaner than littering
>> the otherwise generic code emitter with platform-specifics.
>
> We've also hit this issue, it causes fairly widespread regressions on ELF 
> runtime tests.
>
> I'd tend to agree that's a better fix and I've attached a patch
> following that route. Could someone review it please?

I was about to send exactly the same patch.  Needless to say, it works
for me.

-- 
Måns Rullgård
mans at mansr.com