[llvm-commits] [patch][pr12251] Use the range metadata in computeMaskedBits and add an optimization to InstructionSimplify.

[Duncan Sands]

On 26/03/12 03:48, Rafael Espíndola wrote:
>>> +  for (unsigned i = 0; i<  NumRanges; ++i) {
>>> +    ConstantInt *Lower = cast<ConstantInt>(Ranges.getOperand(2*i + 0));
>>> +    ConstantInt *Upper = cast<ConstantInt>(Ranges.getOperand(2*i + 1));
>>> +    ConstantRange Range(Lower->getValue(), Upper->getValue());
>>> +    if (Range.isWrappedSet())
>>> +      MinLeadingZeros = 0; // -1 has no zeros
>>
>>
>> here you could break out of the loop.
>
> True, but for all current uses NumRanges is 1.

True, but why not be future proof?

Ciao, Duncan.