[llvm-commits] [PATCH] LIT cleanup phase #3 - remove usage of bash

[NAKAMURA Takumi]

2012/3/26 Bendersky, Eli <eli.bendersky at intel.com>:
> So to summarize, without bash support some Lit tests won't run on Windows/MSYS when configured with autoconf?

Yes, as far as weird arguments on RUN: would be still left.
Almost all of failures are due to expression on grep.

> Do you see a way around this, or should bash support stay in for this reason?

Even if bash support would become appendix, I hope bash stayed as one
of options.

Possible workarounds;

  - Rewrite MSYS-incompatible tests not to use grep.
  - Require to install gnuwin32 utilities also on MSYS shell.
    (gnuwin32/bin should not precede MSYS/bin on shell, though)
  - Implement MSYS-compatible escaping and globbing in Lit CMD Runner.
    (Then, we should check escaping compatibility for tools)
  - Provide MSYS-native python.
  - %!@%#%$!@#%$@!#!!!1!!11!!!

In my experience for Lit, MSYS bash brings more accurate results for
shell script. But performance in testing time is worse than CMD Runner
and gnuwin32, esp with -jN.

That said, removing bash would be too earlier.

...Takumi