[llvm-commits] [PATCH] LIT cleanup phase #3 - remove usage of bash

Bendersky, Eli eli.bendersky at intel.com
Mon Mar 26 00:22:50 PDT 2012

> Eli,
> -    isWin32CMDEXE = (litConfig.isWindows and not bashPath)
> +    isWin32CMDEXE = litConfig.isWindows
> Testing on MSYS depends on bash.
> MSYS utilities are incompatible to cmd.exe for globbing and escaping.
> isWin32CMDEXE is assumed to use gnuwin32 tools, not msys utilities.
> With your patch, mingw build would require gnuwin32.
> (cmake build can take gnuwin32, but autoconf build cannot)
> See also the feature "shell" in {llvm|clang}/lit.cfg.
> ...Takumi

Takumi, thanks for the feedback.
So to summarize, without bash support some Lit tests won't run on Windows/MSYS when configured with autoconf? 
Do you see a way around this, or should bash support stay in for this reason?


Intel Israel (74) Limited

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.

More information about the llvm-commits mailing list