[llvm-commits] [PATCH] LIT cleanup phase #3 - remove usage of bash

[NAKAMURA Takumi]

Eli,

-    isWin32CMDEXE = (litConfig.isWindows and not bashPath)
+    isWin32CMDEXE = litConfig.isWindows

Testing on MSYS depends on bash.
MSYS utilities are incompatible to cmd.exe for globbing and escaping.

isWin32CMDEXE is assumed to use gnuwin32 tools, not msys utilities.
With your patch, mingw build would require gnuwin32.
(cmake build can take gnuwin32, but autoconf build cannot)

See also the feature "shell" in {llvm|clang}/lit.cfg.

...Takumi


# On autoconf msys (--targets=x86)
Failing Tests (71):
    Clang :: CodeGen/c-strings.c
    Clang :: CodeGen/funccall.c
    Clang :: CodeGen/inline.c
    Clang :: CodeGen/lineno-dbginfo.c
    Clang :: CodeGenObjC/encode-test-3.m
    Clang :: CodeGenObjC/ivar-layout-64.m
    Clang :: CodeGenObjC/metadata-symbols-32.m
    Clang :: CodeGenObjC/metadata-symbols-64.m
    Clang :: CodeGenObjC/metadata_symbols.m
    Clang :: CodeGenObjC/objc-align.m
    Clang :: CodeGenObjC/synthesize_ivar-cont-class.m
    Clang :: Driver/ast.c
    Clang :: Driver/clang-translation.c
    Clang :: Driver/clang_cpp.c
    Clang :: Driver/flags.c
    Clang :: Driver/mg.c
    Clang :: Driver/unknown-gcc-arch.c
    Clang :: FixIt/fixit-errors-1.c
    Clang :: Frontend/rewrite-macros.c
    Clang :: Index/complete-natural.m
    Clang :: Lexer/preamble.c
    Clang :: PCH/chain-external-defs.c
    Clang :: PCH/missing-file.cpp
    Clang :: PCH/modified-header-crash.c
    Clang :: Preprocessor/cxx_oper_spelling.cpp
    Clang :: Preprocessor/dependencies-and-pp.c
    LLVM :: Linker/2002-07-17-GlobalFail.ll
    LLVM :: Linker/2003-01-30-LinkerRename.ll
    LLVM :: Linker/2003-01-30-LinkerTypeRename.ll
    LLVM :: Linker/2003-04-21-Linkage.ll
    LLVM :: Linker/2003-04-23-LinkOnceLost.ll
    LLVM :: Linker/2003-04-26-NullPtrLinkProblem.ll
    LLVM :: Linker/2003-05-15-TypeProblem.ll
    LLVM :: Linker/2003-05-31-LinkerRename.ll
    LLVM :: Linker/2003-06-02-TypeResolveProblem.ll
    LLVM :: Linker/2003-06-02-TypeResolveProblem2.ll
    LLVM :: Linker/2003-08-20-OpaqueTypeResolve.ll
    LLVM :: Linker/2003-08-23-GlobalVarLinking.ll
    LLVM :: Linker/2003-08-23-RecursiveOpaqueTypeResolve.ll
    LLVM :: Linker/2003-08-24-InheritPtrSize.ll
    LLVM :: Linker/2003-08-28-TypeResolvesGlobal.ll
    LLVM :: Linker/2003-08-28-TypeResolvesGlobal2.ll
    LLVM :: Linker/2003-08-28-TypeResolvesGlobal3.ll
    LLVM :: Linker/2003-10-27-LinkOncePromote.ll
    LLVM :: Linker/2003-11-18-TypeResolution.ll
    LLVM :: Linker/2004-02-17-WeakStrongLinkage.ll
    LLVM :: Linker/2004-05-07-TypeResolution2.ll
    LLVM :: Linker/2004-12-03-DisagreeingType.ll
    LLVM :: Linker/2005-02-12-ConstantGlobals-2.ll
    LLVM :: Linker/2005-02-12-ConstantGlobals.ll
    LLVM :: Linker/2005-12-06-AppendingZeroLengthArrays.ll
    LLVM :: Linker/2006-06-15-GlobalVarAlignment.ll
    LLVM :: Linker/2008-06-13-LinkOnceRedefinition.ll
    LLVM :: Linker/2008-06-26-AddressSpace.ll
    LLVM :: Linker/AppendingLinkage.ll
    LLVM :: Linker/AppendingLinkage2.ll
    LLVM :: Linker/ConstantGlobals1.ll
    LLVM :: Linker/ConstantGlobals2.ll
    LLVM :: Linker/ConstantGlobals3.ll
    LLVM :: Linker/LinkOnce.ll
    LLVM :: Linker/PR8300.ll
    LLVM :: Linker/basiclink.ll
    LLVM :: Linker/inlineasm.ll
    LLVM :: Linker/link-archive.ll
    LLVM :: Linker/link-global-to-func.ll
    LLVM :: Linker/link-type-names.ll
    LLVM :: Linker/multiple-merged-structs.ll
    LLVM :: Linker/redefinition.ll
    LLVM :: TableGen/Slice.td
    LLVM :: Transforms/InstCombine/apint-shift-simplify.ll
    LLVM :: Transforms/ScalarRepl/2003-09-12-IncorrectPromote.ll