[llvm-commits] [patch][pr12251] Add range metadata to llvm. Make clang produce it.

Rafael Espíndola rafael.espindola at gmail.com
Fri Mar 23 17:17:02 PDT 2012


> Incidentally, your code in the verifier makes it look like you actually require a list of pairs, e.g. !{ !{ i8 0, i8 2 } }   or   !{ !{ i8 0, i8 2 }, !{ i8 4, i8 7 } }.  Is there any reason not to just use a flattened list?  Particularly given how the asmprinter prints out nested MDNodes, this would be a lot easier to read and reason about.

Yes, I was using a list of ranges, but for no good reason. I have flattened it.

>
> The verifier doesn't seem to check that LI.getType() matches the Low/High types.
>
> Otherwise, looks great to me!

r153359!

> -Chris

Thanks!

Rafael




More information about the llvm-commits mailing list