[llvm-commits] Is this correct? [polly] r153318 - /polly/trunk/lib/IndVarSimplify.cpp

[Tobias Grosser]

On 03/23/2012 07:27 PM, Andrew Trick wrote:
>
> On Mar 23, 2012, at 1:15 AM, Tobias Grosser<tobias at grosser.es>  wrote:
>
>> Hi Andrew,
>>
>> I am about to fix Polly after your EnableIVRewrite changes. As ether pointed out, your patch was not sufficient to fix compilation, as the simplifyIVUsers function was removed. I worked around this by just not calling it. This works for a very simple test case and was the fastest solution I could find.
>>
>> I do not want to spend too much time on this, as this code should disappear anyway. Still, could you have a short look. Does the patch make sense, assuming we need canonical induction variables, but not minimal scalar code. (Later passes will hopefully clean this up). Is there are simple solution to improve on this?
>>
>
> Hi Tobi,
>
> That's fine. You might have some redundant comparisons that fail to be eliminated. But if you want to generate the best code I think you should get back to using the standard -indvars pass.

OK. That's what I thought. Thanks for confirming.

I am working on eliminating the requirement for this old indvars pass. 
Most of the restructuring of Polly is done, such that the actual patch 
will hopefully be pretty simple. Thanks for your help.

Cheers
Tobi