[llvm-commits] [llvm] r153234 - /llvm/trunk/lib/CodeGen/AsmPrinter/AsmPrinterInlineAsm.cpp

[Eric Christopher]

On Mar 23, 2012, at 11:29 AM, Jim Grosbach <grosbach at apple.com> wrote:

> 
> On Mar 23, 2012, at 11:07 AM, Eric Christopher wrote:
> 
>> 
>> On Mar 23, 2012, at 1:32 AM, Duncan Sands <baldrick at free.fr> wrote:
>> 
>>> Hi Eric,
>>> 
>>>> URL: http://llvm.org/viewvc/llvm-project?rev=153234&view=rev
>>>> Log:
>>>> In erroneous inline assembly we could mistakenly try to access the
>>>> metadata operand as an actual operand, leading to an assert. Error
>>>> out in this case.
>>>> 
>>>> rdar://11007633
>>> 
>>> baldrick bot says: "testcase?"
>> 
>> Yeah, I've got one, but it's going to error out anyhow and for some reason
>> my brain wasn't working with "how to write a testcase that's going to error out
>> anyhow for the backend".
>> 
> 
> You want a test that issues one error but not another?
> 
> I'd do something like:
> 
> ; RUN: not llc <blah blah> < %s 2> %t | FileCheck %s
> ; RUN: FileCheck --check-prefix=CHECK-ERRORS < %t %s
> 
> ; CHECK: normal output check here
> ; CHECK-ERRORS: my-diagnostic-here
> 
> Perhaps with some CHECK-ERRORS-NOT and CHECK-NOT, too.

Sorta, mostly I don't care if it errors. My branes weren't going with "not llc" for some reason.

I blame spring.

-eric